Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix- #155 ] shadowroot to shadowrootmode in DSD #156

Merged
merged 2 commits into from
Jul 21, 2023
Merged

[Fix- #155 ] shadowroot to shadowrootmode in DSD #156

merged 2 commits into from
Jul 21, 2023

Conversation

VinayKrMittal
Copy link

Fix for #155

In DSD shadowroot has been depricated and replaced with shadowrootmode

@VinayKrMittal VinayKrMittal mentioned this pull request Jul 21, 2023
Closed
@Wildhoney
Copy link
Owner

Thanks! Perhaps we need both attrs in the meantime before it’s better supported?

@VinayKrMittal
Copy link
Author

@Wildhoney Right!, we have to keep both the attributes. I have updated the MR , Please Merge this.

@Wildhoney Wildhoney merged commit a173234 into Wildhoney:master Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukul0007 mukul0007 mukul0007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VinayKrMittal @Wildhoney @mukul0007