-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic diffing text file with --display inline (apparently interpreted as sql) #682
Comments
JonathanxD
added a commit
to JonathanxD/difftastic
that referenced
this issue
Apr 5, 2024
Fixes Wilfred#688, fixes Wilfred#694, fixes Wilfred#682, and fixes Wilfred#681.
JonathanxD
added a commit
to JonathanxD/difftastic
that referenced
this issue
Apr 5, 2024
Fixes Wilfred#688, fixes Wilfred#694 and fixes Wilfred#682.
JonathanxD
added a commit
to JonathanxD/difftastic
that referenced
this issue
Apr 6, 2024
Fixes Wilfred#688, fixes Wilfred#694, fixes Wilfred#682 and fixes Wilfred#681. This works around the fact that `str::lines` does not include last newline character. This means that `"a\n".lines().count() == "a".lines().count()`, which breaks the 1:1 assumption made by display implementations.
JonathanxD
added a commit
to JonathanxD/difftastic
that referenced
this issue
Apr 6, 2024
Fixes Wilfred#688, fixes Wilfred#694, fixes Wilfred#682 and fixes Wilfred#681. This works around the fact that `str::lines` does not include last newline character. This means that `"a\n".lines().count() == "a".lines().count()`, which breaks the 1:1 assumption made by display implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I hit a reproducible panic diffing some text file. Running on windows with difft.exe in the path, calling via WSL terminal.
The text was updated successfully, but these errors were encountered: