Support for non-sequential modbus device ID numbers #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Craig Dean <[email protected]>
This was
linked to
issues
Jul 25, 2024
WillCodeForCats
changed the title
|
This feature will be backwards incompatible: the integration to fail setup if the user downgrades without restoring their Home Assistant configuration from backup. |
Config is backwards incompatible with 2.x.x releases.
|
@WillCodeForCats When are you planning to release this version? I would love to switch to this component but I need the non sequential IDs feature in place |
|
There will be a pre-release soon. |
|
Release v3.0.0-pre.1 is now available for testing. |
|
@rzulian Can you test the pre-release? |
It's been working for me for the last few days, but I haven't tried non-sequential IDs with it. |
|
I'm going to try it right now! |
|
Nope, I'm getting an error " [Input/Output] ERROR: No response received after 3 retries" |
|
It is looking for an inverter at ID 3, but that message means there was no response from that ID. Perhaps second inverter is at a different address? |
|
Inverter ID 1 is at 192.168.1.6
Inverter ID 3 is at 192.168.1.8 ID3 is a slave of ID 1
… Il giorno 28 ago 2024, alle ore 18:49, Seth ***@***.***> ha scritto:
It is looking for an inverter at ID 3, but that message means there was no response from that ID. Perhaps second inverter is at a different address?
—
Reply to this email directly, view it on GitHub <#636 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHEOBJF7KMCVMVTRIZR5L7LZTX5QZAVCNFSM6AAAAABLO7AM3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJVHAZTENZSGY>.
You are receiving this because you were mentioned.
|
|
If they're at different IP addresses you would just add two hubs, one for each IP address. |
|
I can try, but using the component "solaredge modbus" with the modification to support multiple inverters, I was using only the first invert IP address |
|
First inverter is working fine, but the second added as a new hub is not It has been a long time ago, but if I remember correctly, the second inverter is accessible from the data in the inverter1 registry |
|
Look at web setapp on your inverters and see what the Unit ID is set to on each of them. Otherwise just try ID 1 on both IP addresses. |
|
I don’t have the web setapp on my inverters.
I can confirm that the unit ID was working with the other component and they were 1 and 3
I’ve tryed your suggestion ID 1 on 192.168.1.8 but it doesn’t work
… Il giorno 28 ago 2024, alle ore 19:06, Seth ***@***.***> ha scritto:
Look at web setapp on your inverters and see what the Unit ID is set to on each of them.
https://github.com/WillCodeForCats/solaredge-modbus-multi/wiki/Configuration#inverter-configuration
Otherwise just try ID 1 on both IP addresses.
—
Reply to this email directly, view it on GitHub <#636 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHEOBJFA4G53GQ63ZFGSWILZTX7SHAVCNFSM6AAAAABLO7AM3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJVHA3DGNZWHA>.
You are receiving this because you were mentioned.
|
|
BTW, this was my pull request with some technical detail about my case and the support for multiple inverters |
|
There must be something unique about your configuration that I don't understand, because I don't see a reason why it shouldn't work. |
I see that adds a configurable The only difference this PR makes is allowing a list of IDs to be configured in the HA front end instead of generating IDs internally with a loop counter. |
|
Also try turning off the option "Auto-Detect Additional Entities" because that causes some inverters to hang: see PR #653 |
|
From the comment in the PR is see that I had to use the |
My integration is using pymodbus, it always has from the first version. |
|
Could you please check the code in this old PR and see if there is something that can be missing in your code. I remember I had to invest a lot of time to let it work, but it was 2021 :( |
|
I went and changed my working system from Device IDs Here's my diagnostic file as proof: config_entry-solaredge_modbus_multi-e3b4ad891a831bb72b37a1247705753f.json |
I really do not see any reason why it shouldn't work. I've supported multiple inverters since the first release, this PR only changes how the list of Device IDs is defined. I created my integration specifically for multiple inverter support and many people use it successfully. Also make sure to disable or remove other integrations that would poll the inverter when you try to use this one. This might also require restarting Home Assistant to resolve library requirements. |
|
Merging since there are enough success reports from the first pre-release. |
|
It's working! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for non-sequential device ID numbers as a list of Modbus/TCP IDs.
List:
1,2,3,4or1,3,10Range:
1-4becomes1,2,3,4Combination:
1-3,5,10becomes1,2,3,5,10Existing configurations will be automatically update by Home Assistant using config migration into a list.
Uses code contributed by @thargy for parsing and validating the ID list format.