Provide IDFT implementation based on cuFFT
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… platforms and boost-internal compiler warnings.
I manually patch it in to avoiid a slew of unwanted chmod +x's
|
Just noticed this got left in "draft". |
|
Initial tests seem giving wrong results? I will do further checks. Does run faster: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from @brandon-feder and I really should have PR'ed it quite a while ago.
The main two commits are Brandon's.
88280c3
I had to cherry pick and and manually patch the commits in order to avoid some problems with many wrong file permissions getting changed and so git doesn't keep the proper attribution (sorry Brandon).
It also sneak in a cherry pick from PR #172 to turn off LZMA dependency in custard to avoid build problems (Spack explicitly turns off LZMA dependency for some reason).
Last commit is just some small cleanups.
Since the
cuda/subpackage was largely empty, I don't expect this needs any significant integration validation effort (it includes a test) but I list you to review, @HaiwangYu just so you can keep tabs.