YZ Dependent Shape and Scale Simulation #270
Conversation
…ased on location within a TPC
| @@ -64,7 +64,7 @@ function(params, tools) | |||
| }, | |||
| }, nin=1,nout=1,uses=[tools.random, anode] + pir_trio), | |||
|
|
|||
| make_depotransform :: function(name, anode, pirs) g.pnode({ | |||
| make_depotransform :: function(name, anode, plane, pirs) g.pnode({ | |||
There was a problem hiding this comment.
You can not change this function signature as it will break existing callers. Given this is such a special purpose I suggest leaving the Jsonnet untouched and simply making your object by hand in the icarus config.
There was a problem hiding this comment.
How about I make it a separate function? It'd be a copy that includes "plane" with a different name. My hope this that this would be usable for SBND (and DUNE) places where there are wrapped wires will have to deal with effects like this
There was a problem hiding this comment.
It would be legitimate to extend the function signature like:
function(name, anode, pirs, planes=[0,1,2])
In this way, old code which does not include planes will get [0,1,2] which is coincident with the default set in the C++.
| } for plane in [0,1,2]], $.fields[r]) | ||
| for r in std.range(0,14) ], |
There was a problem hiding this comment.
You can not change the return value nor introduce icarus specific quantities here.
There was a problem hiding this comment.
how do you recommend addressing this?
There was a problem hiding this comment.
I see already a
cfg/pgrapher/experiment/icarus/icarus_tools.jsonnet
which even has a pirs definition. So, I suggest this would be a good place to further modify.
But, some care is needed to not necessarily step on that if other ICARUS jobs rely on the current, uniform set of pirs.
| double yoffset = 180*units::cm; | ||
| double zoffset = 900*units::cm; |
There was a problem hiding this comment.
You can not use magic numbers in the C++. These should be made configurable parameters.
| if(depo_bin_y > 31) | ||
| depo_bin_y = 31; | ||
|
|
||
| if(depo_bin_z > 180) | ||
| depo_bin_z = 180; |
This pull request enables the simulation of different signal response functions and gain scales in different locations of the ICARUS YZ plane. Currently there are 15 different regions on each plane of each TPC which creates 360 subvolumes that are simulated.
This starts by using a new DepoSetFilter called
DepoSetFilterYZ.This PR requires:
icarus_datain a feature branch calledfeature/jzennamo_addingYZresponsefunctions