Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Champs page#68 #71

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Champs page#68 #71

wants to merge 13 commits into from
+397 −5

Conversation

VincentLeighton
Copy link
Collaborator

@VincentLeighton VincentLeighton commented Jan 10, 2022 •
edited
Loading

Description

Progress on the all champs page addition

Screenshot(s) (if applicable, e.g. style updates)

image

PR Readiness Checklist

  • General
    • Verified all changes are related to feature described above (no scope creep)
  • Branch Stuff
    • Checked target and base branch (should be feature branch merging INTO main)
    • Merged latest main into feature branch (so it has latest code)
    • Resolved any conflicts between feature branch and main
  • Test Stuff
    • Added unit tests to cover modified / additional code
  • GitHub Stuff (on the right 👉)
    • Updated labels
    • Linked issue to which this PR relates
    • Added assignee
    • Added at least one (1) reviewer

@VincentLeighton
ChampDisplayPage#68
3b4b546 
Added Champion Display Page
@VincentLeighton
ChampDisplayPage#68
f0b7b4d 
Added routing and navigation to Chamption Display Page
@VincentLeighton
ChampDisplayPage#68
9bec7fa 
Added component for individual champ to be displayed in champ display page
Added interface for ChampDisplay and added IChampDisplay to index
@VincentLeighton
ChampDisplayPage#68
ef665c7 
Added API calls to static Dragon page for latest version call and all champion data
@VincentLeighton VincentLeighton added the feature New feature or request label Jan 10, 2022
@VincentLeighton VincentLeighton added this to In progress in Next Gen League Compare via automation Jan 10, 2022
@VincentLeighton VincentLeighton linked an issue Jan 10, 2022 that may be closed by this pull request
Add page to display champions #68
Open
@Wolven531 Wolven531 marked this pull request as draft January 10, 2022 02:54
@VincentLeighton
ChampionPage#68
6a09e24 
Completed champion page, added champ images from static png
Updated IChampDisplay and added IChampImage
Updated index
@VincentLeighton
Copy link
Collaborator Author

image

@VincentLeighton
ChampionsPage#68
593ba53 
Added API call to dragon for single champ data call
@VincentLeighton
ChampionsPage#68
c39ac2c 
Added interfaces for champ info and updated index
@VincentLeighton
ChampionsPage#68
ee5e612 
Added routing for ChampDisplay page
@VincentLeighton
ChampionsPage#68
bc27b07 
Added link to ChampInfo page, added ChampInfo page
ChampInfo currently getting champ object but not displaying on page
@VincentLeighton
Merge branch 'main' into ChampsPage#68
00ef8c5
@VincentLeighton
ChampPage#68 Responsive Layout Changes
a480c9f
@VincentLeighton
ChampPage#68 Page Functionality Changes
596f063 
 Update to API return only champ data
@VincentLeighton
ChampPage#68 Use MUI grid layout
f1e9cc8 
IChampInfo cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Wolven531 Wolven531

Labels
feature New feature or request
Projects
@Wolven531's Next Gen League Compare
Status: In Progress
Next Gen League Compare
In progress
Milestone
MVP (Minimum Viable Product)
Development

Successfully merging this pull request may close these issues.

Add page to display champions
2 participants
@VincentLeighton @Wolven531