Adds Process struct for use with the ScriptCompilationSystem in RED4ext #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Octavian Dima <[email protected]>
WopsS
reviewed
May 10, 2023
jackhumbert
changed the title
psiberx
reviewed
May 11, 2023
include/RED4ext/Process.hpp
Outdated
Comment on lines
13
to
18
| struct FixedWString | ||
| { | ||
| uint32_t length; | ||
| uint32_t maxLength; | ||
| const wchar_t* str; | ||
| }; |
There was a problem hiding this comment.
Shouldn't it be WString or WideString or CWideString? Capacity field suggests that this is a mutable string.
There was a problem hiding this comment.
Yeah, you're right - it looks like this is used elsewhere too. I'll do some digging and see what I can find.
WopsS
requested changes
May 11, 2023
Comment on lines
+8
to
+17
| // This file has been generated by zoltan (https://github.com/jac3km4/zoltan) | ||
|
|
||
| #define Process_CloseHandles_Addr 0x2C23B30 | ||
| #define Process_Execute_Addr 0x2C23D70 | ||
| #define Process_Execute_0_Addr 0x2C23DD0 | ||
| #define Process_GetExitCode_Addr 0x2C23B60 | ||
| #define Process_Process_Addr 0x2C23AA0 | ||
| #define Process_ReadFromPipe_Addr 0x2C23B90 | ||
| #define Process_Terminate_Addr 0x2C24040 | ||
| #define Process_WaitUntilCompleted_Addr 0x2C240B0 |
| #define Process_Terminate_Addr 0x2C24040 | ||
| #define Process_WaitUntilCompleted_Addr 0x2C240B0 | ||
|
|
||
| inline bool RED4ext::Process::CloseHandles() |
There was a problem hiding this comment.
Suggested change
| inline bool RED4ext::Process::CloseHandles() | |
| RED4EXT_INLINE bool RED4ext::Process::CloseHandles() |
Same for the others.
| * | ||
| * @return Returns true if the path was added is attached, false otherwise. | ||
| * | ||
| * @pattern 48 89 5C 24 08 57 48 83 EC 40 33 C0 C7 44 24 20 18 00 00 00 48 8D 91 08 20 00 00 48 89 81 00 20 |
There was a problem hiding this comment.
Please move these pattern in the IDA script.
include/RED4ext/Process-inl.hpp
Outdated
| return call(this, a1, a2, a3, a4); | ||
| } | ||
|
|
||
| inline uint64_t RED4ext::Process::GetExitCode() |
There was a problem hiding this comment.
Suggested change
| inline uint64_t RED4ext::Process::GetExitCode() | |
| RED4EXT_INLINE DWORD RED4ext::Process::GetExitCode() |
Comment on lines
+20
to
+38
| enum class ExecutionFlags : std::uint8_t | ||
| { | ||
| // unsets CREATE_NO_WINDOW | ||
| ShouldCreateWindow = 0x1, | ||
| // sets CREATE_BREAKAWAY_FROM_JOB | CREATE_SUSPENDED in Process Creation Flags | ||
| BreakawayAndSuspend = 0x2, | ||
| // unsets bInheritHandles | ||
| NoInheritHandles = 0x4 | ||
| }; | ||
|
|
||
| enum class ReadFlags : std::uint8_t | ||
| { | ||
| // open & read regardless of other options | ||
| Unk1 = 0x1, | ||
| // opens file from name provided and writes output | ||
| WriteToFile = 0x2, | ||
| // writes output to CString | ||
| GetCString = 0x4 | ||
| }; |
There was a problem hiding this comment.
I remembered that we decided to use struct flags, e.g. https://github.com/WopsS/RED4ext.SDK/blob/master/include/RED4ext/RTTITypes.hpp#L117-L132, so please convert these a as well to be consistent.
Comment on lines
+112
to
+113
| // DEFINE_ENUM_FLAG_OPERATORS(Process::ExecutionFlags); | ||
| // DEFINE_ENUM_FLAG_OPERATORS(Process::ReadFlags); |
Comment on lines
+5
to
+6
| #endif | ||
| #include <RED4ext/Relocation.hpp> |
There was a problem hiding this comment.
Suggested change
| #endif | |
| #include <RED4ext/Relocation.hpp> | |
| #endif | |
| #include <RED4ext/Relocation.hpp> |
| @@ -0,0 +1,73 @@ | |||
| #pragma once | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with WopsS/RED4ext#23