Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fockdamping operation #409

Merged
merged 26 commits into from
Aug 5, 2024
Merged

Adding fockdamping operation #409

merged 26 commits into from
Aug 5, 2024

Conversation

kaspernielsen96
Copy link
Collaborator

@kaspernielsen96 kaspernielsen96 commented Jun 7, 2024

Context:
Adding fockdamping operation
Description of the Change:
Adding the bargmann representation of the fockdamping operation.

@kaspernielsen96 kaspernielsen96 added the no changelog Pull request does not require a CHANGELOG entry label Jun 7, 2024
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.70%. Comparing base (25a97a8) to head (e509979).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #409      +/-   ##
===========================================
+ Coverage    88.67%   88.70%   +0.03%     
===========================================
  Files           98       99       +1     
  Lines         6940     6959      +19     
===========================================
+ Hits          6154     6173      +19     
  Misses         786      786              
Files Coverage Δ
mrmustard/lab_dev/transformations/__init__.py 100.00% <100.00%> (ø)
mrmustard/lab_dev/transformations/fockdamping.py 100.00% <100.00%> (ø)
mrmustard/physics/triples.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a97a8...e509979. Read the comment docs.

@kaspernielsen96 kaspernielsen96 marked this pull request as ready for review June 10, 2024 15:07
Copy link
Collaborator

@ziofil ziofil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Although I think for efficiency it's better to define it as a ket-only operator, and then MM will take care of it in case the bra part is needed.

@kaspernielsen96 kaspernielsen96 changed the title Adding fockdamping channel Adding fockdamping operation Jul 9, 2024
@kaspernielsen96
Copy link
Collaborator Author

I updated the channel to be a non trace preserving Operation, which now acts on kets

Copy link
Collaborator

@ziofil ziofil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, though you'll now need to split it out in its own file after Anthony's reassessment of the files and directories. Also, Bargmann needs to be initialized using .from _function

mrmustard/lab_dev/transformations/fockdamping.py Outdated Show resolved Hide resolved
mrmustard/lab_dev/transformations/fockdamping.py Outdated Show resolved Hide resolved
mrmustard/lab_dev/transformations/fockdamping.py Outdated Show resolved Hide resolved
mrmustard/lab_dev/transformations/fockdamping.py Outdated Show resolved Hide resolved
tests/test_physics/test_triples.py Outdated Show resolved Hide resolved
@apchytr apchytr self-requested a review August 5, 2024 15:04
@kaspernielsen96 kaspernielsen96 merged commit d1a2f5a into develop Aug 5, 2024
7 checks passed
@kaspernielsen96 kaspernielsen96 deleted the fockdamp branch August 5, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Pull request does not require a CHANGELOG entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants