-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding fockdamping operation #409
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #409 +/- ##
===========================================
+ Coverage 88.67% 88.70% +0.03%
===========================================
Files 98 99 +1
Lines 6940 6959 +19
===========================================
+ Hits 6154 6173 +19
Misses 786 786
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Although I think for efficiency it's better to define it as a ket-only operator, and then MM will take care of it in case the bra part is needed.
Co-authored-by: Filippo Miatto <[email protected]>
I updated the channel to be a non trace preserving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, though you'll now need to split it out in its own file after Anthony's reassessment of the files and directories. Also, Bargmann needs to be initialized using .from _function
Context:
Adding fockdamping operation
Description of the Change:
Adding the bargmann representation of the fockdamping operation.