Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sauron2 #433

Merged
merged 22 commits into from
Aug 13, 2024
Merged

Sauron2 #433

merged 22 commits into from
Aug 13, 2024

Conversation

ziofil
Copy link
Collaborator

@ziofil ziofil commented Jul 10, 2024

Simpler PR for Sauron states

@ziofil ziofil mentioned this pull request Jul 10, 2024
Closed
@ziofil ziofil added the no changelog Pull request does not require a CHANGELOG entry label Jul 10, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (d0b60a9) to head (51d1a77).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #433      +/-   ##
===========================================
+ Coverage    88.88%   88.92%   +0.03%     
===========================================
  Files          100      101       +1     
  Lines         7020     7042      +22     
===========================================
+ Hits          6240     6262      +22     
  Misses         780      780
Files Coverage Δ
mrmustard/lab_dev/states/__init__.py 100.00% <100.00%> (ø)
mrmustard/lab_dev/states/base.py 96.19% <ø> (ø)
mrmustard/lab_dev/states/sauron.py 100.00% <100.00%> (ø)
mrmustard/physics/triples.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b60a9...51d1a77. Read the comment docs.

arsalan-motamedi
arsalan-motamedi approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@arsalan-motamedi arsalan-motamedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

apchytr
apchytr requested changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@apchytr apchytr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far!

mrmustard/lab_dev/states/states.py Outdated Show resolved Hide resolved
mrmustard/lab_dev/states/states.py Outdated Show resolved Hide resolved
tests/test_lab_dev/test_states/test_states_base.py Outdated Show resolved Hide resolved
apchytr
apchytr reviewed Aug 9, 2024
View reviewed changes
mrmustard/lab_dev/states/sauron.py Outdated Show resolved Hide resolved
mrmustard/lab_dev/states/sauron.py Outdated Show resolved Hide resolved
mrmustard/physics/triples.py Outdated Show resolved Hide resolved
mrmustard/physics/triples.py Outdated Show resolved Hide resolved
mrmustard/physics/triples.py Show resolved Hide resolved
@ziofil ziofil merged commit 84aba1e into develop Aug 13, 2024
7 checks passed
@ziofil ziofil deleted the sauron2 branch August 13, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arsalan-motamedi arsalan-motamedi arsalan-motamedi approved these changes

@apchytr apchytr apchytr approved these changes

Assignees
No one assigned
Labels
no changelog Pull request does not require a CHANGELOG entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ziofil @arsalan-motamedi @apchytr