Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding QuadratureEigenstate #437

Merged
merged 64 commits into from
Aug 5, 2024
Merged

Adding QuadratureEigenstate #437

merged 64 commits into from
Aug 5, 2024

Conversation

kaspernielsen96
Copy link
Collaborator

Context:
Adding the quadrature eigenstate
Description of the Change:
Adding triple, state and tests

@kaspernielsen96 kaspernielsen96 added the no changelog Pull request does not require a CHANGELOG entry label Jul 16, 2024
@kaspernielsen96 kaspernielsen96 marked this pull request as ready for review July 16, 2024 15:34
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (d1a2f5a) to head (9191cdd).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #437      +/-   ##
===========================================
+ Coverage    88.70%   88.75%   +0.05%     
===========================================
  Files           99      100       +1     
  Lines         6959     6982      +23     
===========================================
+ Hits          6173     6197      +24     
+ Misses         786      785       -1     
Files Coverage Δ
mrmustard/lab_dev/states/__init__.py 100.00% <100.00%> (ø)
mrmustard/lab_dev/states/quadrature_eigenstate.py 100.00% <100.00%> (ø)
mrmustard/physics/triples.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a2f5a...9191cdd. Read the comment docs.

Copy link
Collaborator

@apchytr apchytr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far! Just some minor changes

mrmustard/lab_dev/states/__init__.py Outdated Show resolved Hide resolved
mrmustard/lab_dev/states/quadrature_eigenstate.py Outdated Show resolved Hide resolved
mrmustard/lab_dev/states/quadrature_eigenstate.py Outdated Show resolved Hide resolved
mrmustard/lab_dev/states/quadrature_eigenstate.py Outdated Show resolved Hide resolved
@kaspernielsen96 kaspernielsen96 merged commit 4aeafee into develop Aug 5, 2024
7 checks passed
@kaspernielsen96 kaspernielsen96 deleted the quad_eigen branch August 5, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Pull request does not require a CHANGELOG entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants