Physical #447
Merged
Physical #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsalan-motamedi
added
the
no changelog
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #447 +/- ##
===========================================
+ Coverage 88.75% 88.80% +0.05%
===========================================
Files 100 100
Lines 6982 7024 +42
===========================================
+ Hits 6197 6238 +41
- Misses 785 786 +1
Continue to review full report in Codecov by Sentry.
|
- Addressing CodeFactor's issues. - Improving the code for is_CP and is_positive (for Channels and DMs respectively).
… ) as input for modes. - Added the missing test for DM.is_physical
apchytr
reviewed
Aug 1, 2024
ziofil
approved these changes
Aug 1, 2024
- Added .is_physocal for Kets. - Improved code slightly
apchytr
reviewed
Aug 5, 2024
apchytr
reviewed
Aug 5, 2024
apchytr
reviewed
Aug 5, 2024
apchytr
reviewed
Aug 5, 2024
apchytr
reviewed
Aug 5, 2024
apchytr
reviewed
Aug 5, 2024
apchytr
reviewed
Aug 5, 2024
apchytr
reviewed
Aug 5, 2024
apchytr
reviewed
Aug 5, 2024
apchytr
reviewed
Aug 5, 2024
apchytr
reviewed
Aug 5, 2024
apchytr
reviewed
Aug 5, 2024
- Adding self.ATOL in the utils of mrmustard and setting it to 1e-8. This tolerance level is used in checking the positivity conditions and CP conditions. - Improving the code when checking chonditions in the form all(...).
apchytr
reviewed
Aug 5, 2024
apchytr
approved these changes
Aug 5, 2024
apchytr
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Physicality checks added.
Description of the Change:
One can check physicality of a DM
rho, or a Channelchusingrho.is_physicaland/orch.is_physical.Moreover, one can check
ch.is_TP,ch.is_CP, andDM.is_positive.Benefits:
Clear.
Possible Drawbacks:
None.
Related GitHub Issues:
None.