Radiquum changes to furaffinity-dl #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(but yeah it's kludge)
Create directory tree based on author name Filter posts like "YCH OPEN, REMINDER" argument parser changes
added: - filter - remove not fully downloaded file when exiting with CTRL + C - ability to download description as a list - ability to download a specific file changed - color output - remove custom output directory - making of directory tree based off username, category and rating - default attributes value changes - system messages parsing changes - arguments & help text change - move metadata var to section where metadata == True - add page URL to metadata file - some minor changes
- extracted cookie.txt formatting fix
- add shorter arguments - metadata file saving will now be in same folder as an image (it's same as it was before) - print output path when downloaded a specific file
changelog: - new file naming - added possibility to download only recent user submissions (may be useful to update downloaded galleries) - now you can download several users, also you can provide a path to a file with usernames, to download them all - readded custom output path and metadata folder - default args state changes - code cleaning
|
These changes look very good, however this is getting large enough that you should start splitting it into multiple files |
|
This is a significant rewrite with many changes. I'm not sure it should be pulled in all at once? |
well, I guess, I could make it into something like a separate project which is based off this, since it is possible this pull will break something for people who already using original script and I'm not excluding bugs which can happen. still it's for author to decide, to allow or forbid such thing. anyway mostly it's just suggestions, which can be gradually re implemented in a better way, than I did them. |
ability to add comments in username list with "#" autoremoval of "_" in usernames speedup filter checking add basic indexing -> speedup existing file checking for newer files other small changes
- workaround for NTFS filesystem when username ends with dot. - ReadMe changes - other minor changes
Thanks for your pull request, and sorry for the waiting xd
2.Add option to detect comission's category, also introduce new dir structure 3.Check file size when download complete to prevent corrupted file 4.Add option to enable request cache 5.Add option to force check file size to detect corrupted file 6.Fix multiple edge case that will caused exception and corrupt file 7.Fix stack overflow in some cases 8.Add max tries limit when download
Some stability and functional fix
Shoud fix some bugs???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added:
--loginif logged in therechanged:
submission_title - submission_filename