-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gyro controls #17
base: indigo-devel
Are you sure you want to change the base?
Gyro controls #17
Conversation
@@ -275,6 +297,10 @@ void DiffDriveBaseController::update(const ros::Time& now, const ros::Duration& | |||
double right_dx = angles::shortest_angular_distance(right_last_position_, right_pos)/radians_per_meter_; | |||
double left_vel = static_cast<double>(left_->getVelocity())/radians_per_meter_; | |||
double right_vel = static_cast<double>(right_->getVelocity())/radians_per_meter_; | |||
double effort_l = static_cast<double>(left_->getEffort()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the effort that is being read from the motor being used anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No not being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove the getEffort part.
Other than a few comments, LGTM. Once you make the suggested changes, could you rebase everything to a single commit? |
Yes will do. I was just waiting for the demo to get over to do the final On Thu, Apr 28, 2016 at 10:35 AM, Derek [email protected] wrote:
Bhavya Dayananda Kattapuni |
P controller using gyro feedback gain on effort around 6 gain on velocity around 0.8
This is the code without the testing enhancements