-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require responses<=0.23.1 #69
Conversation
Require responses<=0.23.1 to resolve dependency conflicts (e.g., with Home Assistant integrations) pending upstream resolution getsentry/responses#657 home-assistant/core#97248
@@ -26,5 +26,5 @@ def read(fname): | |||
packages=['forecastio'], | |||
package_data={'forecastio': ['LICENSE.txt', 'README.rst']}, | |||
long_description=open('README.rst').read(), | |||
install_requires=['requests>=1.6', 'responses'], | |||
install_requires=['requests>=1.6', 'responses<=0.23.1'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct. responses
is for testing, it does not belong in this install_requires
list at all.
I’m not sure why this PR is being made? This project is dead now that Dark Sky doesn’t exist any more. |
The Pirate Weather project -- which includes a Home Assistant custom component -- relies on this module: https://github.com/alexander0042/pirateweather/ Just trying to come up with a quick-and-dirty fix to prevent the dependency conflict from breaking unsuspecting users' Home Assistant instances while minimizing changes to this project... |
Thanks for sharing Pirate Weather! Very cool project. I think you'll want to fork this project so you can maintain it yourself. You'll notice the last commit to the master branch was in 2018 and it looks like the owner of the repo hasn't interacted with GitHub since 2020. |
This dependency conflict was resolved for purposes of the Pirate Weather custom component via a package constraint for Closing this PR as no longer necessary. Thanks, all. |
@krazos That is a temporary solution and not permanent. It is not a solution either. Just to be clear on that. Pirate Weather still needs to adjust, if they don't, it will break soon. |
Require responses<=0.23.1 to resolve dependency conflicts introduced by responses 0.23.2 (e.g., with Home Assistant integrations) pending upstream resolution
getsentry/responses#657
home-assistant/core#97248