Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added building support for UE1 and UE2 games. #23

Open
wants to merge 1 commit into
base: ST3
Choose a base branch
from

Conversation

EliotVU
Copy link
Contributor

@EliotVU EliotVU commented Jan 15, 2014

This patch adds environment detecting for UE1/UE2 and UE3, and instigates the correct .exe file for each environment.

Known issues:
The options given after selecting are not working except for launching the game without a selected map.

For example given the commandline:
UT2004.exe 127.0.0.1?SpectatorOnly=0 -log -newwindow

Works as expected when doing it by hand, but when done by the plugin UT2004 thinks that the -log and -newwindow params are part of 127.0.0.1(or map's name). I don't know why, but maybe you know if Python or Sublime Text is doing something weird there.

Note: Does not support caching, debugging, and anything else really, but Syntax highlighting and building.
Warning: I have commented out some IMPORTANT? lines as they did not make any sense to me as to what they are and they were preventing me from adding support, so don't blindly apply this patch without fixing those line if you can :) (Marked by FIXME or TODO)

@Zinggi
Copy link
Owner

Zinggi commented Jan 15, 2014

I need some time to read through those changes and see if you've broken something ;-)

What does the "?ide=1 " parameter do?
Also this doesn't screw up this, right?

Those command lines never really worked well for me (using python). When using the udk.cmd, the parameters needed to be different than when using the udk.exe. Also if you had spaces somewhere, ...don't even try.

@Zinggi
Copy link
Owner

Zinggi commented Jan 15, 2014

ahh this file is quite a mess -.-

@EliotVU
Copy link
Contributor Author

EliotVU commented Jan 15, 2014

Indeed it is, and my lack of any work in Python is certainly making it look even more spaghetti like ^^

I don't think it would break that path. IDE is just made up I added that because in my test example UT2004.exe was adding options like ?foo=foo on commandline arguments like -newwindow so I thought maybe I have to ensure there to be at least one option but no that did nothing... so I just leave it as a nice way to indicate that the game was executed from within an IDE, (can be read by UnrealScript). But remove it if it causes any trouble.

@Zinggi
Copy link
Owner

Zinggi commented Jan 15, 2014

Well this breaks the compile options for me (ctrl + alt + b). Could you try to tweak it again, so that it doesn't break anything?
Or I can maybe have a look at it tomorrow.

@EliotVU
Copy link
Contributor Author

EliotVU commented Jan 15, 2014

Ah, so that's what the line that I commented out is for, I had to comment it out as it interferes with the UE2 support and I didn't know what to do with it to fix it for both, solution seems simple if Environment is not UE1/UE2 then skip that logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants