don't pin requests in setup.py
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump? |
|
Anything I can do to facilitate this getting merged? As you can see here pypa/pip#988 (comment) pip has now merged their constraint-based dependency resolver, which means that this overly-strict constraint is eventually going to start breaking installs of things that use togglwrapper whereas it would previously only show a warning. |
aarose
approved these changes
Mar 25, 2021
|
@glyph Thank you so much for your contribution! 🙏 And for everyone's patience |
|
and TIL about the difference between the two (requirements.txt vs setup), thank you. |
aarose
added a commit
that referenced
this pull request
Mar 25, 2021
don't pin `requests` in setup.py
|
Thanks so much for the continued maintenance @aarose ! I know how hard it can be to make time for open source stuff particularly in this past year. Do you have plans for a PyPI release soon? |
|
Yeah, version 1.2.1 should be out now! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks again for releasing togglwrapper.
While pinning all dependencies in CI is a good idea to avoid contributors having to deal with spurious version-upgrade problems as they're trying to contribute unrelated fixes, it's unfortunately a problem for applications, which need to upgrade their dependencies on a more regular cadence than togglwrapper maintenance has bandwidth for. There's always the possibility of a new version of
requestsbreaking things, but that's really the responsibility of therequestsmaintainers to keep things working.This distinction between
setup.pyandrequirements.txtis somewhat subtle, but Donald Stufft tried to explain it in some depth here: https://caremad.io/posts/2013/07/setup-vs-requirement/Separately from this PR, it might be good to
get a (free!) account on Requires.io,turn on Dependabot which can automatically send you a PR when any of your Python dependencies upgrade, which will take care of bothrequirements.txtandtest_requirements.txtfor you.