[#106] Address new url.Parse behavior during setup #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fix #106? |
It resolves the issue for me and is the most minimal approach I could come up with to address the issue. There's no telling when the author may rule on this PR, so feel free to use the master branch in my fork until then. My master branch is diverged from this repo only insofar as the import paths are concerned and to include my changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should address the new
url.Parsebehavior. The relative SSH URL portion is treated as a port. Since ports parsed byurl.Parsemust now be numeric, this breaks relative SSH URLs.The approach I took was to inject a temporary port number, parse the URL, and remove the injected port. All tests pass. That being said, this code needs more eyes on it to make sure all edge cases are addressed by these changes.