Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigModule 2.0 #41

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

ConfigModule 2.0 #41

wants to merge 9 commits into from

Commits on Jun 19, 2019

  1. Upgrade Uspec dev dependency.

    @acook
    acook committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    c2c7d7a View commit details
    Browse the repository at this point in the history

  2. Starting the path to 2.0!

    @acook
    acook committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    1303248 View commit details
    Browse the repository at this point in the history

  3. Adding Rubocop config for newer versions.

    @acook
    acook committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    4e01400 View commit details
    Browse the repository at this point in the history

  4. Rubocop suggestions fixed 

     - Empty newlines after guard clauses
 - Converted conditionally-wrapped rescue block into one with a guard
 clause
 - Removed redundant freeze on immutable string
    @acook
    acook committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    98b9425 View commit details
    Browse the repository at this point in the history

  5. Setup method takes options in a block DSL.

    @acook
    acook committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    361b388 View commit details
    Browse the repository at this point in the history

  6. A test file ended up in the wrong directory.

    @acook
    acook committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    7eac313 View commit details
    Browse the repository at this point in the history

  7. Freeze strings in setup spec.

    @acook
    acook committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    d41e65c View commit details
    Browse the repository at this point in the history

  8. Rubocop suggestions.

    @acook
    acook committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    948797a View commit details
    Browse the repository at this point in the history

  9. Merge pull request #20 from acook/setup 

    Setup method takes options in a block DSL.
    @acook
    acook committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    8f4b7e7 View commit details
    Browse the repository at this point in the history