improve summary #127
Merged
improve summary #127
+8
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
commented
Jan 2, 2020
|
|
||
| # What's new | ||
|
|
||
| - Improved fetch performance | ||
| - The default behavior now fetches only the commit being checked-out | ||
| - Improved performance |
There was a problem hiding this comment.
I simplified the What's new section to make it easier to skim
Also the summary is more verbose now, so I didn't want to repeat all details.
ericsciple
commented
Jan 2, 2020
| @@ -6,27 +6,26 @@ | |||
|
|
|||
| This action checks-out your repository under `$GITHUB_WORKSPACE`, so your workflow can access it. | |||
There was a problem hiding this comment.
The existing summary does not have enough details and folks are getting tripped up by the fetch-depth 1 default
ericsciple
commented
Jan 2, 2020
| - Improved layout | ||
| - The input `path` is always relative to $GITHUB_WORKSPACE | ||
| - Aligns better with container actions, where $GITHUB_WORKSPACE gets mapped in | ||
| - Fallback to REST API download | ||
| - When Git 2.18 or higher is not in the PATH, the REST API will be used to download the files | ||
| - When using a job container, the container's PATH is used |
There was a problem hiding this comment.
this tripped up a customer migrating from v1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #125
fixes #126