Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit filename when downloading Windows go package #250

Merged

Conversation

jromero
Copy link
Contributor

@jromero jromero commented Jul 29, 2022

Description:
Use explicit filename when downloading Windows go package.

Using the explicit filename for Windows is necessary to satisfy Expand-Archive's requirement on .zip extension.

The solution can be seen working here (screenshot).


Credit goes to @redanthrax for finding the root cause.

This PR differs from #242 in the following ways:

  1. When available, uses RUNNER_TEMP env var similar to tool-cache.
  2. Added tests for the implemented scenario.
  3. It DOES NOT update tool-cache library (to minimize changes).

Related issue:

Fixes #241

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Using the explicit filename for Windows is necessary to
satisfy `Expand-Archive`'s requirement on '.zip' extension.

Signed-off-by: Javier Romero <[email protected]>
@jromero jromero requested a review from a team July 29, 2022 00:15
@jromero
Copy link
Contributor Author

jromero commented Aug 3, 2022

@dmitry-shibanov / @marko-zivic-93 Any insight as to when this may be merged and/or released?

@marko-zivic-93 marko-zivic-93 merged commit f279813 into actions:main Aug 4, 2022
@milas
Copy link

milas commented Aug 9, 2022

I just saw this after updating a job to use 1.19 on a shared runner - any chance we can get a v3.2.2 released?

@panticmilos
Copy link
Contributor

Hi @milas, we will get release for this today or tomorrow :)

@panticmilos
Copy link
Contributor

panticmilos commented Aug 12, 2022

Hi guys, just to update you, the release will be at the start of the next week instead. We were waiting for one more feature to include in the release.

@jromero jromero deleted the feature/windows-download-filename branch August 16, 2022 14:40
@panticmilos
Copy link
Contributor

@jromero, @milas new release is out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants