Migrate dev environment and workflows to node16 #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhammerl
changed the title
fhammerl
commented
Dec 22, 2022
| @@ -219,6 +219,13 @@ export class DownloadHttpClient { | |||
| fileDownloadPath: string | |||
| ): Promise<void> => { | |||
| destinationStream.close() | |||
| // await until file is created at downloadpath; node15 and up fs.createWriteStream had not created a file yet | |||
There was a problem hiding this comment.
Node16 regression:
The single code change we need in node16: awaiting destinationStream.on('close', ensures that the file has been created so we can rmFile delete it on line 229.
Phantsure
reviewed
Dec 22, 2022
| @@ -24,10 +24,10 @@ jobs: | |||
| - name: Checkout | |||
| uses: actions/checkout@v2 | |||
|
|
|||
| - name: Set Node.js 12.x | |||
| - name: Set Node.js 16.x | |||
| uses: actions/setup-node@v1 | |||
There was a problem hiding this comment.
setup-node can also be updated to v3?
…rl/node-v16-and-toolkit-fixes
Releases can be made or PRs can be merged even if the workflow is failing
rentziass
approved these changes
Jan 3, 2023
This was referenced Jan 5, 2023
This was referenced Jul 1, 2024
Open
This was referenced Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix critical audit vulnerabilities, we needed to upgrade (dev) dependencies to versions that are no longer compatible with our current workflows using node12.
Node12 and node16 are the versions used by the runner. With Node12 being deprecated, we've targeted node16 for this project as well. It makes sense to keep in sync with the runner, as most eventual applications of
actions/tookit's packages end up being executed by the runner.Also contains numerous fixes to satisfy
audit-all