i can solve problems #586
Open
i can solve problems #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v2.9.3 release
…ogging. Prompted by a user report (https://groups.google.com/forum/#!topic/markdown-here/ikXFqkP77Ws) of Firefox options access errors. Couldn't reproduce, so no idea if this fixes the problem.
v2.9.4 release
…g. Now making request to background script.
…fine in Chrome. Some debug code and text still present
… a sane way to localize install.rdf.
… translations. Added translators section to CONTRIBUTE.md
…e now sorted to help minimize diff noise (going forward).
… behaviour should now be accounted for.
Merge WebExtensions changes
This is related to #173, but the fix for that didn't check deeply enough.
This seemed to occur in Chrome on all pages, and in Firefox on some pages (Gmail, but not the contenteditable test page).
Forgot-to-Render check for Fastmail
- CSS for the preference dialogs has moved - NsISupportsString in setComplexValue() has been dropped in favour of setStringPref() - Thunderbird 60 refusing explicit decliration of option type 1 in install.rdf
Thunderbird 60 Fixes
And copy over some linting stuff from the defunct xul branch.
Fix #495: Stopped working in Thunderbird 60
A string added in the Firefox 60 fix wasn't copied to the non-English `messages.json` files, which meant that it wasn't in the non-English `strings.properties` and `string.dtd` files. This caused Thunderbird to not load the overlay in Thunderbird, which prevented it from being present in the message window. To help mitigate this in the future, to some degree, the `i18n.js` script makes sure that all English strings are present in the other languages when creating the the .properties and .dtd files. But I still have to remember to run that script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please share the code