Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zip64 support for ZipArchive extraction #205

Merged
merged 1 commit into from
Jan 24, 2017

Conversation

markryd
Copy link
Contributor

@markryd markryd commented Jan 24, 2017

I've taken a first cut at some limited zip64 support. It is extract only and only on the Archive API at this point.

Note: I'm casting 8 byte values to long instead of supporting the full ulong as it simplifies the implementation quite a bit. Things like Reader.Seek take a long directly, it's easy enough to cover that with multiple reads but I ended up backing away as it made the change much larger for minimal benefit (9 Exabyte archive size limitation instead of 18 etc). Also CLS compliance means we can't expose ulong. More than happy to revisit that if required.

@adamhathcock
Copy link
Owner

Looks good to me, thanks!

Does CLS compliance matter a lot? I guess if there is a demand for 9+ exabyte files then that can be another fix :)

@adamhathcock adamhathcock merged commit 079a818 into adamhathcock:master Jan 24, 2017
@adamhathcock
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants