Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid headers #210

Merged
merged 2 commits into from
Mar 9, 2017
Merged

Fix invalid headers #210

merged 2 commits into from
Mar 9, 2017

Conversation

kenkendk
Copy link
Contributor

@kenkendk kenkendk commented Mar 9, 2017

This fixes a bug introduced with 6be6ef0.

Bad news is that all zip files written with 0.15.1 are semi-broken.
That is, their filenames are garbled, but content is recoverable.

@adamhathcock adamhathcock merged commit d0b4af6 into adamhathcock:master Mar 9, 2017
@adamhathcock adamhathcock mentioned this pull request Mar 9, 2017
Closed
@kenkendk
Copy link
Contributor Author

kenkendk commented Mar 9, 2017

As far as I can see the code here is not used, so my panic was unjustified.

For some reason, the ZipHeader has an abstract Write method, and all the subclasses implement it, but none of them call it.
This would only cause problems if someone were to manually construct the items and call the write methods.

@kenkendk kenkendk mentioned this pull request Mar 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenkendk @adamhathcock