Added support for VectorDrawable #19
Conversation
… selectedDrawableTint properly)
|
Hello, thanks for the PR! I'll hopefully spend some time checking this out in more detail to fully understand it. But, do you mind adding a "unit test" to demonstrate this feature? Essentially, just add another item to the sample activity that shows it working. In addition, I would recommend testing the feature on a few different Android versions (I usually do API19, API21, and API26 or 27) just to be sure. |
…works with vector drawable. Tested on API 19, 21, 27 & 28.
|
Hi! Take a look at the example which I provided in the sample activity. It's tested on different API versions. |
|
Can you explain why you took I changed the code to just return a
|
Everything seems to work with just utilizing the VectorDrawable
| android:id="@+id/buttonGroup_vectorDrawable" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:layout_margin="4dp" |
There was a problem hiding this comment.
Oh yeah, the margin bottom will need to be 60dp here.
This was just so I could move the button to be up higher on the device screen for some reason.
|
The bug appears on API 28. The
After converting |
…Button into master-support
Limit the conversion from vector to bitmap to only API 28 since its fixed on 29?
|
Wow, what a crazy bug. It's gone on API 29, so I made adjustments to the code to only convert from vector to bitmap in API 28. My thought process is that keeping the vector as a vector drawable is more efficient (in terms of memory) than converting to a bitmap. Although, in the end, the performance/memory differences is likely minimal. Everything looks good! I'll add the new sample GIF and release a new version. Thanks |
Added checking drawable type in SegmentedButton. If the drawable is Vector, it will be converted into a bitmap. This allows to handle drawable tint/selected tint properly.