chore(deps): update ember and drop node 12 support

BREAKING CHANGE: Drop support for Node v12 and Ember LTS 3.24
adfinis · Sep 7, 2022 · 3f3fb67 · 3f3fb67
1 parent 1281a62
commit 3f3fb67
Show file tree

Hide file tree

Showing 8 changed files with 360 additions and 129 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -104,8 +104,8 @@ jobs:
     strategy:
       matrix:
         scenario:
+          - ember-lts-4.4
           - ember-lts-3.28
-          - ember-lts-3.24
           - ember-release
           - ember-beta
           - ember-canary

diff --git a/.gitignore b/.gitignore
@@ -31,3 +31,6 @@
 /package.json.ember-try
 /package-lock.json.ember-try
 /yarn.lock.ember-try
+
+# broccoli-debug
+/DEBUG/
diff --git a/addon/components/validated-input/types/select.js b/addon/components/validated-input/types/select.js
@@ -1,4 +1,3 @@
-import { A as emberArray, isArray } from "@ember/array";
 import { deprecate } from "@ember/debug";
 import EmberObject, { action, get } from "@ember/object";
 import Component from "@glimmer/component";
@@ -31,7 +30,8 @@ export default class SelectComponent extends Component {
 
   get hasPreGroupedOptions() {
     return (
-      this.args.options[0]?.groupName && isArray(this.args.options[0]?.options)
+      this.args.options[0]?.groupName &&
+      Array.isArray(this.args.options[0]?.options)
     );
   }
 
@@ -61,26 +61,26 @@ export default class SelectComponent extends Component {
     if (!groupLabelPath) {
       return this.args.options;
     }
-    const groups = emberArray();
+    const groups = [];
 
     this.args.options.forEach((item) => {
       const label = get(item, groupLabelPath);
 
       if (label) {
-        let group = groups.findBy("groupName", label);
+        let group = groups.find((group) => group.groupName === label);
 
         if (!group) {
           group = EmberObject.create({
             groupName: label,
-            options: emberArray(),
+            options: [],
           });
 
-          groups.pushObject(group);
+          groups.push(group);
         }
 
-        group.options.pushObject(this.normalize(item));
+        group.options.push(this.normalize(item));
       } else {
-        groups.pushObject(item);
+        groups.push(item);
       }
     });
 

diff --git a/config/ember-try.js b/config/ember-try.js
@@ -8,18 +8,18 @@ module.exports = async function () {
     useYarn: true,
     scenarios: [
       {
-        name: "ember-lts-3.24",
+        name: "ember-lts-3.28",
         npm: {
           devDependencies: {
-            "ember-source": "~3.24.3",
+            "ember-source": "~3.28.1",
           },
         },
       },
       {
-        name: "ember-lts-3.28",
+        name: "ember-lts-4.4",
         npm: {
           devDependencies: {
-            "ember-source": "~3.28.1",
+            "ember-source": "~4.4.0",
           },
         },
       },

diff --git a/package.json b/package.json
@@ -39,20 +39,20 @@
     "ember-changeset": "^4.1.0",
     "ember-changeset-validations": "^4.1.0",
     "ember-cli-babel": "^7.26.11",
-    "ember-cli-htmlbars": "^6.0.1",
+    "ember-cli-htmlbars": "^6.1.0",
     "ember-truth-helpers": "^3.0.0"
   },
   "devDependencies": {
     "@adfinis-sygroup/eslint-config": "1.5.0",
     "@adfinis-sygroup/semantic-release-config": "3.4.0",
     "@ember/optional-features": "2.0.0",
     "@ember/test-helpers": "2.8.1",
-    "@embroider/test-setup": "1.6.0",
+    "@embroider/test-setup": "1.8.3",
     "@fortawesome/ember-fontawesome": "0.4.0",
     "@fortawesome/free-solid-svg-icons": "6.1.1",
     "babel-eslint": "10.1.0",
     "broccoli-asset-rev": "3.0.0",
-    "ember-cli": "4.3.0",
+    "ember-cli": "4.6.0",
     "ember-cli-addon-docs": "ember-learn/ember-cli-addon-docs#667701d60650cf7af51611dbff9abf1879776421",
     "ember-cli-dependency-checker": "3.3.1",
     "ember-cli-deploy": "1.0.2",
@@ -76,11 +76,11 @@
     "ember-try": "2.0.0",
     "eslint": "7.32.0",
     "eslint-config-prettier": "8.5.0",
-    "eslint-plugin-ember": "10.6.1",
+    "eslint-plugin-ember": "11.0.2",
     "eslint-plugin-import": "2.26.0",
     "eslint-plugin-node": "11.1.0",
-    "eslint-plugin-prettier": "4.0.0",
-    "eslint-plugin-qunit": "7.2.0",
+    "eslint-plugin-prettier": "4.2.1",
+    "eslint-plugin-qunit": "7.3.1",
     "husky": "8.0.1",
     "lint-staged": "13.0.3",
     "loader.js": "4.7.0",
@@ -91,7 +91,7 @@
     "webpack": "5.74.0"
   },
   "engines": {
-    "node": "12.* || 14.* || >= 16"
+    "node": "14.* || >= 16"
   },
   "ember": {
     "edition": "octane"

diff --git a/tests/dummy/config/ember-cli-update.json b/tests/dummy/config/ember-cli-update.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "name": "ember-cli",
-      "version": "4.3.0",
+      "version": "4.6.0",
       "blueprints": [
         {
           "name": "addon",

diff --git a/tests/dummy/config/environment.js b/tests/dummy/config/environment.js
@@ -21,10 +21,6 @@ module.exports = function (environment) {
         // Here you can enable experimental features on an ember canary build
         // e.g. EMBER_NATIVE_DECORATOR_SUPPORT: true
       },
-      EXTEND_PROTOTYPES: {
-        // Prevent Ember Data from overriding Date.parse.
-        Date: false,
-      },
     },
 
     APP: {