WIP: Make CoreDNS manifests v1.8 #8
Conversation
|
Hi, thank you for your PR, I'll review it in a while🤘 |
| data: | ||
| {{- if .Values.coredns.enabled }} | ||
| coredns.yaml: | | ||
| {{- tpl (.Files.Get "manifests/coredns-1.8.yaml") . | nindent 4 }} |
There was a problem hiding this comment.
Is there any specific reason for specifying version in filename?
There was a problem hiding this comment.
It depends on whether you'd like to support several CoreDNS versions simultaneously. Because CoreDNS version does not have strict mapping on Kubernetes version in fact.
There was a problem hiding this comment.
It depends on whether you'd like to support several CoreDNS versions simultaneously
How are two coredns versions can act together in single cluster?
CoreDNS version does not have strict mapping on Kubernetes version in fact.
That's true, but it has some defaults in kubeadm:
https://github.com/kubernetes/kubernetes/blob/5e58841cce77d4bc13713ad2b91fa0d961e69192/cluster/addons/dns/coredns/coredns.yaml.base#L134-L135
Co-authored-by: Andrei Kvapil <[email protected]>
Resolves #3