Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows aria2 executables per architecture #1056

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

149segolte
Copy link
Contributor

@149segolte 149segolte commented Sep 17, 2021

Description

Package architecture-specific executables with Motrix.

Related Issues

As mentioned in the comment, #271 (comment), Motrix did not ship 64bit aria2 in windows binaries was because of packaging issues in electron builder.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully run the app with your changes locally?

@149segolte
Copy link
Contributor Author

@agalwood, I have looked into agalwood/aria2 but have not been able to understand, if the aria2c.exe is compiled by the CI for this repository or is it simply copied over?
Currently, in the last commit of this draft, the x64 folder contains a copy of the ia32 aria2c.exe. Locally I have tested this using official aria2 release binaries.
Can you provide me with the 64bit binary or should I use the official binary?
As for agalwood/aria2, since that repo is 74 commits behind, is it going to be rebased to the recent aria2 release?

@149segolte 149segolte marked this pull request as ready for review September 24, 2021 05:36
@149segolte
Copy link
Contributor Author

I have opened a PR at agalwood/aria2#1 to bump aria2 to 1.36.0. The windows binaries used in the PR are generated from 1.36.0. As for Linux and macOS, maybe a separate PR can be opened for them.

@agalwood
Copy link
Owner

Thanks for your contribution. I will update aria2 to the latest version.

@agalwood agalwood merged commit 6039a89 into agalwood:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants