Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug regarding cookie/referer #1428

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Conversation

CW-B-W
Copy link
Contributor

@CW-B-W CW-B-W commented Apr 14, 2023

Problem

When cookie/referer are set at the same time, aria2 failed to parse the cookie/referer arguments, and the target cannot be downloaded.
If only cookie is set, aria2 can successfully download the target.

Description

Because

result[kebabCaseKey] = `${options[key]}`

joins the array element with ','

Adapt it to

result[kebabCaseKey] = options[key].join('\n')

works on my side

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran app with your changes locally?

When cookie/referer are set at the same time, aria2 failed to
parse the cookie/referer arguments.
If only cookie is set, aria2 can successfully download the target.
@agalwood
Copy link
Owner

Thanks for your fix 👍

@agalwood agalwood merged commit af6e0f3 into agalwood:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants