Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Complete translation into Arabic #919

Merged
merged 18 commits into from
May 5, 2021
Merged

fix: Complete translation into Arabic #919

merged 18 commits into from
May 5, 2021

Conversation

AhmedElTabarani
Copy link
Contributor

@AhmedElTabarani AhmedElTabarani commented May 4, 2021

Description

Complete translation into Arabic

Related Issues

Complete this pull request #833

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran app with your changes locally?

@AhmedElTabarani
Copy link
Contributor Author

@agalwood i have some question

  1. spaces before functions
function checkLngIsAvailable (locale)

export function getLanguage (locale = 'en-US')

I can't do npm run dev until put space before these function, why ? I push it with these spaces anyway

After I install node_modules files, There is some modifies occurred on the yarn.lock file, I push it also!

I should not upload the package-lock.json file, right? I can delete it from this pull request

@AhmedElTabarani
Copy link
Contributor Author

What is this !!?, I don't know why the pull request has the last 14 commit !!!!
I was editing my commit only, and did a forces push, I didn't do any things with last 14 commits.

@AhmedElTabarani
Copy link
Contributor Author

I fixed every thing, you can merge it now

src/shared/locales/ar/app.js Show resolved Hide resolved
src/shared/locales/ar/preferences.js Outdated Show resolved Hide resolved
src/shared/locales/ar/preferences.js Outdated Show resolved Hide resolved
@hadialqattan
Copy link
Contributor

Nice work bro @AhmedElTabarani!

@agalwood
Copy link
Owner

agalwood commented May 5, 2021

Thank you for your translation contributions. @AhmedElTabarani @hadialqattan

The 13 commits were made when I was developing new features. New release will coming soon : >

I think your use of force-pushed is a dangerous operation, and you should use it as little as possible or not.

@agalwood agalwood changed the title Complete translation into Arabic fix: Complete translation into Arabic May 5, 2021
@agalwood agalwood merged commit 1cfec28 into agalwood:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants