Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections import #3258

Merged
merged 4 commits into from
Sep 9, 2018
Merged

Collections import #3258

merged 4 commits into from
Sep 9, 2018

Conversation

BeatButton
Copy link
Contributor

In Python 3.8, importing abstract base classes from collections instead of collections.abc will stop working.

This is a pretty minor change, so I don't know that more explanation is necessary, or whether I should actually be added to the list of contributors, but shrug.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-io
Copy link

codecov-io commented Sep 9, 2018

Codecov Report

Merging #3258 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3258      +/-   ##
==========================================
- Coverage   98.03%   97.99%   -0.04%     
==========================================
  Files          43       43              
  Lines        7885     7886       +1     
  Branches     1354     1354              
==========================================
- Hits         7730     7728       -2     
- Misses         63       65       +2     
- Partials       92       93       +1
Impacted Files Coverage Δ
aiohttp/multipart.py 96.02% <100%> (ø) ⬆️
aiohttp/tcp_helpers.py 90% <0%> (-6.67%) ⬇️
aiohttp/client_reqrep.py 97.47% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de4daf3...7a3829a. Read the comment docs.

@webknjaz webknjaz merged commit c8c0567 into aio-libs:master Sep 9, 2018
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants