Fix incorrect image tensor shape #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akash-akya I will check in the next 24 hours. I suspect it will require an update on my side. And this may explain some unexpected behaviour I had to work around. Will revert ASAP. |
kipcole9
added a commit
to elixir-image/image
that referenced
this pull request
Oct 16, 2023
Due to [the fix](akash-akya/vix#129) for [this issue](akash-akya/vix#126) in [vix](https://github.com/akash-akya/vix), a fix is applied in `Image.nx/2` to ensure correct operation. There should be no change to user code other than the requirement for the versions of `image` and `vix` to correctly match. This release of `image` requires `vix` version `0.23` to ensure compatibility.
|
@akash-akya, I've updated image to reflect this change. As expected, I needed to modify I will publish an |
|
Thanks for the update! I'll merge and push new version today |
|
@kipcole9 |
|
I've published image version 0.38.3. Thanks for the early warning Akash, much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126
Hi @kipcole9, can you check if this breaks something in image?