Shorten processingAgent label in Document schema #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
followthemoney/schema/Document.yaml
Outdated
| @@ -112,10 +112,11 @@ Document: | |||
| label: "Processing error" | |||
| hidden: true | |||
| processingAgent: | |||
| label: "Processing agent" | |||
| label: "Name and version of the processing agent used to process the Document" | |||
There was a problem hiding this comment.
Keeping the long version is fine I think, but you’d need to change the key to description ;)
followthemoney/schema/Document.yaml
Outdated
| label: "Name and version of the processing agent used to process the Document" | ||
| type: string | ||
| hidden: true | ||
| processedAt: | ||
| label: "Date and time of the most recent ingestion of the Document" |
There was a problem hiding this comment.
Maybe shorten that one two (to "Processed at")? Even though it’s hidden, we might decide to show it in the future, and it’s also displayed in the FtM model explorer etc.
stchris
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.