Update default model & add a check #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/build.yml
Outdated
| then | ||
| echo "Default model is up to date 👌" | ||
| else | ||
| echo "⚠️ Default model is not up to date. You need to run `make default-model` and commit the changes." |
There was a problem hiding this comment.
Does this only print the message in the logs or does it actually exit with a non-zero status code?
There was a problem hiding this comment.
Oh shoot, good point, I forgot to exit. Thanks @tillprochaska !
There was a problem hiding this comment.
Updated the else branch.
stchris
force-pushed
the
update-default-model
branch
from
3d4eb9b
to
bbce6d6
Compare
tillprochaska
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the JSON model file after the 3.5.8 release.
I also added a CI check to make sure that file is up-to-date.