fix: Fixed extern functions clashing names, and trying to use wrong decl

alinalihassan · May 7, 2022 · 238406d · 238406d
1 parent aed2cd9
commit 238406d
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/liblesma/Backend/Codegen.cpp b/src/liblesma/Backend/Codegen.cpp
@@ -442,12 +442,9 @@ void Codegen::visit(ExternFuncDecl *node) {
         paramTypes.push_back(visit(param.second));
 
     FunctionType *FT = FunctionType::get(visit(node->getReturnType()), paramTypes, false);
-    Function *F = Function::Create(FT, Function::ExternalLinkage, node->getName(), *TheModule);
+    auto F = TheModule->getOrInsertFunction(node->getName(), FT);
 
-    for (auto &param: F->args())
-        param.setName(node->getParameters()[param.getArgNo()].first);
-
-    Scope->insertSymbol(node->getName(), F, F->getFunctionType());
+    Scope->insertSymbol(node->getName(), F.getCallee(), F.getFunctionType());
 }
 
 void Codegen::visit(Assignment *node) {