fix: Fixed memory leak due to unused modules

alinalihassan · Mar 10, 2022 · 4d2282f · 4d2282f
1 parent a0088a9
commit 4d2282f
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/src/Backend/Codegen.cpp b/src/Backend/Codegen.cpp
@@ -90,7 +90,6 @@ void Codegen::CompileModule(Span span, const std::string &filepath) {
                     Scope->insertSymbol(name, (Value *) &(*it).getFunction(), (*it).getFunctionType());
             }
 
-            Modules.push_back(codegen->getModule());
         } else {
             std::string obj_file = fmt::format("tmp{}", ObjectFiles.size());
             codegen->WriteToObjectFile(obj_file);
@@ -188,12 +187,6 @@ void Codegen::LinkObjectFile(const std::string &obj_filename) {
 }
 
 int Codegen::JIT() {
-    //    Commented out for now, the linker seems to just copy the functions over to the main module
-    //    for (auto &module: Modules) {
-    //        auto jit_error = TheJIT->addModule(std::move(module));
-    //        if (jit_error)
-    //            throw CodegenError("JIT Error:\n{}");
-    //    }
     auto jit_error = TheJIT->addModule(ThreadSafeModule(std::move(TheModule), std::move(TheContext)));
     if (jit_error)
         throw CodegenError({}, "JIT Error:\n{}");

diff --git a/src/Backend/Codegen.h b/src/Backend/Codegen.h
@@ -48,7 +48,6 @@ namespace lesma {
         std::stack<llvm::BasicBlock *> continueBlocks;
         std::stack<std::vector<llvm::Value *>> deferStack;
 
-        std::vector<ThreadSafeModule> Modules;
         std::vector<std::string> ObjectFiles;
         llvm::Function *TopLevelFunc;
         bool isBreak = false;