fix: fixed type comparison having errors

alinalihassan · Apr 24, 2023 · 8d85145 · 8d85145
1 parent 1bcccf7
commit 8d85145
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/src/liblesma/Symbol/Type.h b/src/liblesma/Symbol/Type.h
@@ -68,11 +68,21 @@ namespace lesma {
         void setReturnType(lesma::Type *type) { returnType = type; }
 
         bool isEqual(Type *rhs) {
-            if (this == nullptr && rhs == nullptr)
+            if (rhs == nullptr)
+                return false;
+
+            if (this->getBaseType() != rhs->getBaseType())
+                return false;
+
+            Type *thisElementType = this->getElementType();
+            Type *rhsElementType = rhs->getElementType();
+
+            if (thisElementType == nullptr && rhsElementType == nullptr)
                 return true;
-            if (this == nullptr || rhs == nullptr)
+            if (thisElementType == nullptr || rhsElementType == nullptr)
                 return false;
-            return this->getBaseType() == rhs->getBaseType() && this->getElementType()->isEqual(rhs->getElementType());
+
+            return thisElementType->isEqual(rhsElementType);
         }
 
         [[nodiscard]] std::string toString() const {