-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWGEM:LMee: Adding new KFParticle variables to TreeMaker #22449
base: master
Are you sure you want to change the base?
Conversation
e902453: approval required: 1 of @atoia (Alberica Toia), @chiarazampolli (Chiara Zampolli), @davidrohr (David Rohr), @dsekihat (Daiki Sekihata), @hmurakam (Hikari Murakami), @iarsene (Ionut Cristian Arsene), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @ktf (Giulio Eulisse), @otonvd (Oton Vazquez Doce), @pzhristov (Peter Hristov), @qgp (Jochen Klein), @rbailhac (Raphaelle Bailhache), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan), @tkgunji (Taku Gunji), @wiechula (Jens Wiechula) Comment with |
+1 |
e902453: approved: will be automatically merged on successful tests |
Error while checking build/AliPhysics/root6 for e902453 at 2023-07-05 18:28:
Full log here. |
@TimoWilken |
Hi @jjungIKF! I was referring to the following lines you added after the new set(LIBDEPS ${ALIPHYSICS_DEPENCIES} ${ALIROOT_DEPENDENCIES} ${ROOT_DEPENDENCIES})
generate_rootmap("${MODULE}" "${LIBDEPS}" "${CMAKE_CURRENT_SOURCE_DIR}/${MODULE}LinkDef.h") In your previous PR, I think you didn't delete the same lines further above (lines 136+137), but now it seems you have. I'm still a bit confused why you've done this -- doesn't the Also, in this case, presumably set(LIBDEPS ${ALIPHYSICS_DEPENCIES} ${ALIROOT_DEPENDENCIES} ${ROOT_DEPENDENCIES})
generate_rootmap("${MODULE}" "${LIBDEPS}" "${CMAKE_CURRENT_SOURCE_DIR}/${MODULE}LinkDef.h") When you compile and run locally, do you specifically run the Apart from this CMake change I explained above, nothing immediately jumps out at me as a possible cause of the timeout... |
Thank you for the fast reply @TimoWilken |
Hi @jjungIKF, I've marked this PR as draft to avoid long delays for other PRs. Let me know if those unit tests work locally for you! |
Hi @TimoWilken, |
@TimoWilken |
+test |
No description provided.