-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alibuild recipe (reference) : requirements #771
base: master
Are you sure you want to change the base?
Conversation
Adding extra details about the logic I understood for the fields : requires, build_requires, runtime_requires (after mail exchanges with Adrian Sevcenco, Giulio Eulisse + some local tests on one alidist recipe (lhapdf.sh). To be revised by Giulio to make sure that this is correct.
Codecov Report
@@ Coverage Diff @@
## master #771 +/- ##
=======================================
Coverage 87.23% 87.23%
=======================================
Files 29 29
Lines 2984 2984
=======================================
Hits 2603 2603
Misses 381 381 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thank you for this. We should probably check the the runtime_requires behave correctly. I do no think we ever used them... |
I confess that I discovered the |
docs/reference.markdown
Outdated
the "required" corresponding binaries, libraries and environment variables | ||
will be made available (by loading the dependency module) before the current built starts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you confirm that a requires
or build_requires
load the dependency module before the build starts ?
I mean, it is a "casual" loading of module, there is nothing extra or specific (bin, lib, env) due to the fact that we are about to compile a new package ? In other words, loading a module, be it for a coming built-time or run-time, is the same ?
(I was not sure about this).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not the dependency module, they load the build environment of the dependencies. aliBuild has no idea about modulefiles.
Apparently it is not the full module of the dependency which is loaded before the build requiring it starts, it is the build environment only.
Update of the TOC to match the section content (build env, runtime env, ...)
Marking this as draft, as the CI builder errors out without the changes in #789 If there's still interest to get this merged, could you rebase this on master? The file is now located at |
Adding extra details about the logic I understood for the fields :
This comes after some mail exchanges with Adrian Sevcenco, Giulio Eulisse + some local tests on one alidist recipe (lhapdf.sh).
To be revised by Giulio to make sure that this is correct.