Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flatbuffers and use internal flatbuffers in ONNXRuntime #5413

Closed
wants to merge 3 commits into from

Conversation

davidrohr
Copy link
Contributor

No description provided.

@davidrohr davidrohr requested a review from a team as a code owner April 1, 2024 09:23
Copy link
Member

@ktf ktf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we simply move flatbuffers to a version which everyone likes? I would prefer not having two versions.

@davidrohr
Copy link
Contributor Author

davidrohr commented Apr 11, 2024 via email

@ktf
Copy link
Member

ktf commented Apr 11, 2024

Fair enough, but why bumping it, then? Is it required to get the new GCC working? If yes, how come the internal version does work?

@davidrohr
Copy link
Contributor Author

davidrohr commented Apr 11, 2024 via email

@ktf
Copy link
Member

ktf commented May 1, 2024

@davidrohr do you understand the issue on cs8?

@davidrohr
Copy link
Contributor Author

@ktf : which issue on cs8?

@ktf
Copy link
Member

ktf commented May 2, 2024

yesterday it was failing. maybe it was simply a glitch in the wrong package.

@davidrohr
Copy link
Contributor Author

Now Ubuntu fails, but it was green before. So I think it is more random ctests failing.
@pzhristov : What is the status of the tests with analysis? Can we merge this?

@ktf
Copy link
Member

ktf commented May 2, 2024

Yes, indeed ubuntu is unrelated.

@davidrohr
Copy link
Contributor Author

no longer needed with onnx bumped to 1.18

@davidrohr davidrohr closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants