Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ROOT to v6.32.02-alice1 #5535

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Bump ROOT to v6.32.02-alice1 #5535

merged 1 commit into from
Aug 15, 2024

Conversation

ktf
Copy link
Member

@ktf ktf commented Jul 3, 2024

No description provided.

@ktf ktf requested a review from a team as a code owner July 3, 2024 19:51
@Barthelemy
Copy link
Contributor

DO NOT MERGE

we agreed with Giulio to wait until we are back from holidays.

@ktf
Copy link
Member Author

ktf commented Jul 19, 2024

@shahor02 @sawenzel @davidrohr this is now failing with

./sim-challenge.log[ERROR]  - Device trd-globaltracking_TPC_FT0_ITS-TPC_CTP_: pid 18773 (exit 128)
./sim-challenge.log[INFO]    - First error: [WARN] MC-truth is not supported for FT0 recpoints currently
./sim-challenge.log[INFO]    - Last error: Backtrace complete.

any idea of what might be going on?

@shahor02
Copy link
Contributor

Not sure, it crashes when filling GPU data structures :
./sim-challenge.log[18773:trd-globaltracking_TPC_FT0_ITS-TPC_CTP_]: /sw/slc8_x86-64/O2/5535-slc8_x86-64-local7/lib/libO2GPUWorkflowHelper.so: o2::gpu::GPUWorkflowHelper::fillIOPtr(o2::gpu::GPUTrackingInOutPointers&, o2::globaltracking::RecoContainer const&, bool, o2::gpu::GPUCalibObjectsTemplateo2::gpu::ConstPtr const*, o2::gpu::gpustd::bitset<32u>, o2::gpu::gpustd::bitset<32u>, o2::gpu::gpustd::bitset<32u>)

But fullCI has converged in other PRs after this one crashing, so might be related to this PR. Could you restart fullCI to check if it is reproducible?

@ktf
Copy link
Member Author

ktf commented Jul 19, 2024

I wonder if it's not related to:

./itstpcMatch.log[16548:itstpc-track-writer]: Error in <TStreamerInfo::Build>: o2::dataformats::AbstractRef<25,5,2>, unknown type: typename std::conditional<(32> mRef

which we have a few lines above.

@shahor02
Copy link
Contributor

I've never seen this error before, apparently caused by the new root version. But then, the failing TRD reco is by far not the 1st workflow to use these structures.

@ktf
Copy link
Member Author

ktf commented Jul 20, 2024

@shahor02 the issue seems to have indeed been solved by AliceO2Group/AliceO2#13310. I would say the remaining one (missing libxandr-devel I guess), must be a newly introduced system dependency somewhere in ROOT. I will ask @singiamtel to add it to the docker container on Monday.

@ktf
Copy link
Member Author

ktf commented Jul 20, 2024

@Barthelemy this is ready to be tested on your side whenever you are ready.

@ktf
Copy link
Member Author

ktf commented Jul 22, 2024

I tested this on hyperloop and the basic tests seem fine (even a lower memory usage for the Correlation workflow).

@Barthelemy
Copy link
Contributor

I tested this branch and it works for me. ROOT out of the RPMs is functional. I don't think that we should wait longer. Let's merge it if you agree @ktf @vascobarroso

@ktf ktf merged commit 118dcf3 into master Aug 15, 2024
15 of 16 checks passed
@ktf ktf deleted the ktf-patch-10 branch August 15, 2024 12:21
@ktf
Copy link
Member Author

ktf commented Aug 15, 2024

Merging this so that we can spot issue early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants