Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM: Bump hdf5, numpy, scipy, Keras/tf and pandas #5547

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

singiamtel
Copy link
Collaborator

The CI for ARM is complaining about tensorflow, had to bump some versions. Tested on pip 21.2.3 and Python 3.9.18

@mfasDa do you agree with the changes? (follow-up to #5539)

Closes #5524 and #5525 too

The error:

2024-07-09@12:48:57:DEBUG:Python-modules:Python-modules:slc9_aarch64: Collecting Keras==2.7.0
2024-07-09@12:48:57:DEBUG:Python-modules:Python-modules:slc9_aarch64:   Downloading keras-2.7.0-py2.py3-none-any.whl (1.3 MB)
2024-07-09@12:48:57:DEBUG:Python-modules:Python-modules:slc9_aarch64:      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.3/1.3 MB 22.1 MB/s eta 0:00:00
2024-07-09@12:48:57:DEBUG:Python-modules:Python-modules:slc9_aarch64: ERROR: Could not find a version that satisfies the requirement tensorflow==2.7.1 (from versions: 2.10.0rc0, 2.10.0rc1, 2.10.0rc2, 2.10.0rc3, 2.10.0, 2.10.1, 2.11.0rc0, 2.11.0rc1, 2.11.0rc2, 2.11.0, 2.11.1, 2.12.0rc0, 2.12.0rc1, 2.12.0, 2.12.1, 2.13.0rc0, 2.13.0rc1, 2.13.0rc2, 2.13.0, 2.13.1, 2.14.0rc0, 2.14.0rc1, 2.14.0, 2.14.1, 2.15.0rc0, 2.15.0rc1, 2.15.0, 2.15.1, 2.16.0rc0, 2.16.1, 2.16.2, 2.17.0rc0, 2.17.0rc1)
2024-07-09@12:48:57:DEBUG:Python-modules:Python-modules:slc9_aarch64: ERROR: No matching distribution found for tensorflow==2.7.1

@singiamtel singiamtel requested a review from a team as a code owner July 9, 2024 12:44
@mfasDa
Copy link
Contributor

mfasDa commented Jul 9, 2024

@singiamtel As discussed in the other PR I am also in favour of bumping to newer versions of sklearn, numpy, pandas, tensorflow and Keras, I just did the minimal changes to get tensorflow back in for older python versions, and leave the aligned version bump to you.

@singiamtel
Copy link
Collaborator Author

singiamtel commented Jul 9, 2024

For what it's worth, this PR bypasses the same problem #5459

Copy link
Member

@ktf ktf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to break aligenerators, actually...

@singiamtel singiamtel force-pushed the arm_python_modules_build branch 2 times, most recently from c791593 to e679175 Compare July 22, 2024 11:50
@singiamtel singiamtel force-pushed the arm_python_modules_build branch 3 times, most recently from e1ecc0a to 15c5907 Compare July 23, 2024 16:20
@ktf
Copy link
Member

ktf commented Jul 24, 2024

@singiamtel Looks like we are missing a -DHDF5_DIR=... or something like that. Could you take a look?

Needed to compile in ARM with python3.9, otherwise Keras and tensorflow
complain about incompatible versions

Tested on pip 21.2.3 and Python 3.9.18

```
2024-07-09@12:48:57:DEBUG:Python-modules:Python-modules:slc9_aarch64: Collecting Keras==2.7.0
2024-07-09@12:48:57:DEBUG:Python-modules:Python-modules:slc9_aarch64:   Downloading keras-2.7.0-py2.py3-none-any.whl (1.3 MB)
2024-07-09@12:48:57:DEBUG:Python-modules:Python-modules:slc9_aarch64:      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.3/1.3 MB 22.1 MB/s eta 0:00:00
2024-07-09@12:48:57:DEBUG:Python-modules:Python-modules:slc9_aarch64: ERROR: Could not find a version that satisfies the requirement tensorflow==2.7.1 (from versions: 2.10.0rc0, 2.10.0rc1, 2.10.0rc2, 2.10.0rc3, 2.10.0, 2.10.1, 2.11.0rc0, 2.11.0rc1, 2.11.0rc2, 2.11.0, 2.11.1, 2.12.0rc0, 2.12.0rc1, 2.12.0, 2.12.1, 2.13.0rc0, 2.13.0rc1, 2.13.0rc2, 2.13.0, 2.13.1, 2.14.0rc0, 2.14.0rc1, 2.14.0, 2.14.1, 2.15.0rc0, 2.15.0rc1, 2.15.0, 2.15.1, 2.16.0rc0, 2.16.1, 2.16.2, 2.17.0rc0, 2.17.0rc1)
2024-07-09@12:48:57:DEBUG:Python-modules:Python-modules:slc9_aarch64: ERROR: No matching distribution found for tensorflow==2.7.1
```
@ktf
Copy link
Member

ktf commented Jul 24, 2024

@singiamtel it looks like it's still broken.

hdf5.sh Show resolved Hide resolved
hdf5.sh Outdated Show resolved Hide resolved
@ktf
Copy link
Member

ktf commented Jul 25, 2024

Ok, fixed now.

@ktf ktf merged commit 5daa9a9 into alisw:master Jul 25, 2024
13 of 14 checks passed
@ktf
Copy link
Member

ktf commented Jul 25, 2024

Errors on ARM are the next issue to support the platform. Merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants