forked from KitwareMedical/SlicerPipelines
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline creator mk2 #1
Open
Connor-Bowley
wants to merge
22
commits into
allemangD:main
Choose a base branch
from
Connor-Bowley:pipeline-creator-mk2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start of the deprecation process for the old pipeline creator.
Can create pipelines, but missing some bells and whistles. Can create pipelines with multiple inputs.
Adds ability to load the pipeline module upon creation. Adds ability to automatically add the pipeline module directory to the additional module paths.
Was writing "True" instead of "true", so it wasn't working correctly.
Can now optionally test a pipeline before it gets fully generated.
Rename PipelineCreatorMk2 to just PipelineCreator
Add pipeline wrappings for all SurfaceToolbox operations.
Cannot select no pipeline. Must select a pipeline or cancel.
There is no good reason the pipeline needs a name to be able to test it. Requiring a name is annoying to the user.
Not all conversions to/from segmentations have been implemented yet.
If an intermediate node is referenced by the final output, don't delete it with the rest of the intermediates.
Add pipelines from VTK and SegmentEditor to new pipeline creator that were in the legacy pipeline creator.
The min and max threshold values were being overwritten when the segmentation was set on the segmentEditorWidget. Delaying parameter set until the very end to ensure the given parameters are used.
Add explicit test to make sure connecting a derived class output to a base class input passes validation. Update PipelineListWidget's ReferenceComboBox to allow connecting a derived class output reference to a base class input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames old pipeline creator stuff to have "Legacy" prefix.
Adds new pipeline creator that can handle multiple input, multiple output.