Update to handle new Register API response format #562
Conversation
|
I'm assuming the build is failing because I can't trigger Travis builds with access to the necessary secrets and whatnot? |
Yes, we have our own copy of phantomjs in a private S3 bucket due to rate limiting on the bitbucket site and Travis CI doesn't decrypt the environment vars for PRs since that could be exploited to reveal the secret. I'd welcome suggestions on how to fix that without opening up the download to the whole world. 😄 |
|
Makes sense. I'm assuming there's a reason you don't just run |
Yes - it's all documented in ariya/phantomjs#13953. I'm trying to just rely on the phantomjs in the path in PR #563. |
Registers have not been returning data in this format for a long time. No need to keep the old code around.
The response you receive from a request for the `/records` endpoint is changing. This will be a breaking change. This change provides support for both the old and new response style whilst we transition. The biggest change here is the addition of a list of items under the `item` [sic] key within each record. For the Country Register this will only contain a single item.
samcrang
force-pushed
the
update-to-use-new-register-api
branch
from
2f960cf
to
84a3f40
Compare
|
Build has gone green! 😄 |
|
@samcrang thanks! 👍 When is the new format going live? |
|
Thanks! Hopefully Monday, 3rd April. We'll issue a clean-up PR after we've done it if that helps you out? |
Better get a deploy out then, hadn't I 😄
That'd be great, thanks 👍 |
|
Ha, totally forgot you'd still have to deploy 😄. Sorry about the super-late notice on this. |
|
@pixeltrix did the deploy go okay? Are we good to deploy our side on Monday? |
|
Yes, we deployed |
The response you receive from a request for the
/recordsendpoint on a Register is changing. This will be a breaking change. This PR provides support for both the old and new response style whilst we transition.We're looking to publish an ADR which describes the rationable for the breaking change.
We should be deploying this change soon. We'll send a second PR to remove the code to handle the old format after we've deployed.