More numpythonic osc funcs, now w/ more args (phase, amp, duty cycle)

[jbdoar]

Fixes # .

Changes proposed in this pull request:

Mentions: @alxrsngrtn @jbdoar

[alxmrs]

Looks good.

Nit: Instead of using single-line comments for low and hi pass, use a """docstring""".

[alxmrs]

Before merge, please make sure bin/bish still works.

[jbdoar]

Before merge, please make sure bin/bish still works.

Good idea. Do you have any minimal working examples of how to get that part of the project to work? I haven't figured it out yet.

[alxmrs]

Yes -- I believe examples should be documented in the help message of the script. So, running bin/bish --help will do the trick. I think you will hit import errors before then.

[jbdoar]

Well, flattening the file structure of the hcm library certainly has introduced some errors--we certainly won't wish to merge anything yet.

[jbdoar]

Alright, so: when I try running bish, I get this error, flagging line 39 in the io module:
AttributeError: module 'rx' has no attribute 'Observer'

Any thoughts on where that might be coming from? In case it matters, I have rx version 3.1.1 installed on my machine, which differs from the version in your requirements.txt.

[alxmrs]

Ah. So the rx api has changed from our reqs to the latest release. The easy fix would be to uninstall rx and pip install -r requirements.txt. We also could refactor our use of rx in the project to use the latest api. The latter is a lot of effort, so I'm ok with doing the former.

[jbdoar]

Will need more reviewing before merge. Presently I am no longer getting errors when running bish, but it's not driving my speakers, either...

[alxmrs]

hmm... it looks like bin/bish was deleted in this branch. How should I test it?

[alxmrs]

I see you moved the file from bin. Please update setup.py to point to this new location of bish:

scripts=['hcm/bish']

[jbdoar]

I'm sure there was a better way than moving bish into the main directory, but for whatever reason it wasn't finding hcm when I tried running it out of the bin folder.

[alxmrs]

it's not driving my speakers

I see. I filed a bug for this, I can look into and fix it. Once you update setup.py, this PR is good to go.

[alxmrs]

LGTM, after minor change to setup.py.