-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More numpythonic osc funcs, now w/ more args (phase, amp, duty cycle) #23
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Nit: Instead of using single-line comments for low and hi pass, use a """docstring""".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merge, please make sure bin/bish
still works.
Good idea. Do you have any minimal working examples of how to get that part of the project to work? I haven't figured it out yet. |
Yes -- I believe examples should be documented in the help message of the script. So, running |
Well, flattening the file structure of the hcm library certainly has introduced some errors--we certainly won't wish to merge anything yet. |
Alright, so: when I try running bish, I get this error, flagging line 39 in the io module: Any thoughts on where that might be coming from? In case it matters, I have rx version 3.1.1 installed on my machine, which differs from the version in your requirements.txt. |
Ah. So the rx api has changed from our reqs to the latest release. The easy fix would be to uninstall rx and |
I think we can get rid of VCO now, but it's still in bish and I didn't want to delete it for that reason
Will need more reviewing before merge. Presently I am no longer getting errors when running bish, but it's not driving my speakers, either... |
hmm... it looks like |
dunno how it disappeared from the branch
@@ -11,7 +11,7 @@ from hcm import types | |||
SAMPLE_RATE = 8000 # hz | |||
INTERVAL_LENGTH = 1000 # ms | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you moved the file from bin
. Please update setup.py
to point to this new location of bish:
scripts=['hcm/bish']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure there was a better way than moving bish into the main directory, but for whatever reason it wasn't finding hcm when I tried running it out of the bin folder.
I see. I filed a bug for this, I can look into and fix it. Once you update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after minor change to setup.py.
Fixes # .
Changes proposed in this pull request:
Mentions: @alxrsngrtn @jbdoar