Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw RuntimeException at all #444

Closed
amitjoy opened this issue Dec 7, 2022 · 0 comments · Fixed by #445
Closed

Don't throw RuntimeException at all #444

amitjoy opened this issue Dec 7, 2022 · 0 comments · Fixed by #445
Labels
enhancement New feature or request

Comments

@amitjoy
Copy link
Owner

amitjoy commented Dec 7, 2022

It's not a good practice to throw RuntimeException at all as it is quite top-level exception to understand what it is. Instead of it, we should throw VerificationException or use Verify.verify().
@amitjoy amitjoy added the enhancement New feature or request label Dec 7, 2022
amitjoy added a commit that referenced this issue Dec 7, 2022
@amitjoy
Removed use of throwing RuntimeException where unnecessary
a12c8a6 
fixes #444
@amitjoy amitjoy mentioned this issue Dec 7, 2022
Merged
@amitjoy amitjoy added this to the v3.0.0 milestone Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed use of throwing RuntimeException where unnecessary amitjoy/osgifx
1 participant
@amitjoy