Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instead of copying array for decoding, just use backed array from byte buffer #582

Closed
amitjoy opened this issue Apr 22, 2023 · 0 comments · Fixed by #583
Closed

Instead of copying array for decoding, just use backed array from byte buffer #582

amitjoy opened this issue Apr 22, 2023 · 0 comments · Fixed by #583
Labels
enhancement New feature or request
Milestone
v2.4.0

Comments

@amitjoy
Copy link
Owner

amitjoy commented Apr 22, 2023

Currently the MQTT RPC copies the contents to a new array from the byte buffer which costs significant CPU cycles, whereas, we can simple use the backing array
@amitjoy amitjoy added the enhancement New feature or request label Apr 22, 2023
@amitjoy amitjoy added this to the v2.4.0 milestone Apr 22, 2023
amitjoy added a commit that referenced this issue Apr 22, 2023
@amitjoy
Use of backing array from the ByteBuffer
40c06c6 
closes #582
@amitjoy amitjoy mentioned this issue Apr 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging a pull request may close this issue.

Use of backing array from the ByteBuffer amitjoy/osgifx
1 participant
@amitjoy