Allow user to specify media options on request. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User can provide an optional 'get_media_options' function to the options object, which will take the default_media_options as a parameter and can return an arbitrary object. This is intended to allow, among other things, users requesting resolutions other than the ones in the default_media_options.
|
Yes, even in latest Firefox 58 on android, I am getting this issue, but not on chrome browser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is intended to address #30.
The application code can specify a 'get_media_options' function during construction, which is passed the
default_media_optionsand returns an arbitrary options object.In our case we could request the maximum possible resolution from Firefox using the following code, after which it is no longer capped at 640x.