fix(firestore): use new ref/query when changing from/to undefined

andipaetzold · Oct 15, 2021 · 981ec92 · 981ec92
1 parent 046f92a
commit 981ec92
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/firestore/internal.ts b/src/firestore/internal.ts
@@ -54,7 +54,7 @@ export async function getDocsFromSource<Value extends DocumentData = DocumentDat
  * @internal
  */
 function isDocRefEqual<Value>(a: DocumentReference<Value> | undefined, b: DocumentReference<Value> | undefined): boolean {
-    const areBothUndefined = a === undefined || b === undefined;
+    const areBothUndefined = a === undefined && b === undefined;
     const areSameRef = a !== undefined && b !== undefined && refEqual(a, b);
     return areBothUndefined || areSameRef;
 }
@@ -72,7 +72,7 @@ export function useStableDocRef<Value>(
  * @internal
  */
 function isQueryEqual<Value>(a: Query<Value> | undefined, b: Query<Value> | undefined): boolean {
-    const areBothUndefined = a === undefined || b === undefined;
+    const areBothUndefined = a === undefined && b === undefined;
     const areSameRef = a !== undefined && b !== undefined && queryEqual(a, b);
     return areBothUndefined || areSameRef;
 }