Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance light theme #1141

Merged
merged 25 commits into from
Aug 18, 2024
Merged

Enhance light theme #1141

merged 25 commits into from
Aug 18, 2024

Conversation

Isthisanmol
Copy link
Collaborator

No description provided.

Copy link

cloudflare-pages bot commented Jul 25, 2024

Deploying packrat with  Cloudflare Pages  Cloudflare Pages

Latest commit: 68fa8d9
Status: ✅  Deploy successful!
Preview URL: https://d7709f66.packrat.pages.dev
Branch Preview URL: https://enhance-light-theme.packrat.pages.dev

View logs

Copy link

github-actions bot commented Jul 25, 2024

❌ Tests failed for this pull request. 😞

View Test Workflow

Copy link

github-actions bot commented Jul 25, 2024

Android APK build completed!
You can download the APK file from the following link:
https://github.com/andrew-bierman/PackRat/actions/runs/10255017057#artifacts

@JewelTee
Copy link
Collaborator

@Isthisanmol I noticed the sign-in component blends into the background, making it less prominent. Maybe we can adjust the contrast or consider using a darker background for the sign in form.
Screenshot 2024-07-26 144654

@JewelTee
Copy link
Collaborator

@Isthisanmol also from the home page, maybe we can change the background color of these buttons to a different blue shade (lighter) ?

image

@EngrAJ8888
Copy link
Collaborator

Hi @Isthisanmol, I've noticed a few pages with broken UI. Please refer to the photos below.
image
image

  • The "See All" button is overlapping with the "Create a Pack" button.
    image

  • The native app is crashing when creating or viewing a pack

@andrew-bierman
Copy link
Owner

the cards in /feed should be full width I believe

@andrew-bierman
Copy link
Owner

the sign in rounded box / card is not stretched to full width, it might look better how it was previously (only fit-content width)

@andrew-bierman
Copy link
Owner

great work those these are super small cleanup tasks, this is looking awesome

@taronaleksanian
Copy link
Collaborator

@andrew-bierman @JewelTee I'll fix those issues on my refacotiring branch, I merged this branch with mine.

@andrew-bierman andrew-bierman merged commit 352565c into andrew_testing Aug 18, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants